Bug 223 : API CHANGE - rename ServerConfig logging property names
Priority 
High
Reported Version 
 
Logged By 
Rob
Status 
Fixed
Fixed Version 
2.4.0
Assigned To 
 
Product 
Ebean - core
Duplicate Of 
 
Created 
23/02/2010
Updated 
23/02/2010
Type 
Bug
 
Attachments 
No attachments

From a couple of comments the properties associated with logging are confusing (and I completely agree with that). I believe these suggested new names are better and will make it easier for people to find the related logging properties in their IDE via autocomplete etc.

ServerConfig:

Old property names       -> New property names

useJuliTransactionLogger -> loggingToJavaLogger
transactionLogDirectory  -> loggingDirectory
transactionLogSharing    -> loggingLogFileSharing

transactionLogging       -> loggingLevel
iudLogLevel              -> loggingLevelIud
queryLogLevel            -> loggingLevelQuery
sqlQueryLogLevel         -> loggingLevelSqlQuery
transactionDebugLevel    -> loggingLevelTxnCommit
 
Rob 23 Feb 07:23
Benefits

The benefit I see with these property names is that someone goes "setLog" in their IDE and autocomplete will show the related "logging" properties. I also think it is easier way to see how the logging level properties are related (loggingLevel being the overall transaction logging level).

Rob 23 Feb 07:25
enum changes ...

Additionally some of the enum names have been changed.

New names of Enum types.

Old enums    -> New enums

TxLogSharing -> LogFileSharing

TxLogLevel   -> LogLevel
TxDebugLevel -> LogLevelTxnCommit
StmtLogLevel -> LogLevelStmt

Rob 23 Feb 07:31
Fixed in HEAD

Fixed in HEAD.

Rob 23 Feb 07:33
ebean.properties

Setting these in ebean.properties

## Use java util logging to log transaction details
#ebean.loggingToJavaLogger=true

## General logging level: (none, explicit, all)
ebean.logging=all

## Sharing log files: (none, explicit, all)
ebean.logging.logfilesharing=all

## location of transaction logs 
ebean.logging.directory=logs
#ebean.logging.directory=${catalina.base}/logs/trans

## Specific Log levels (none, summary, binding, sql)
ebean.logging.iud=sql
ebean.logging.query=sql
ebean.logging.sqlquery=sql

## Log level for txn begin, commit and rollback (none, debug, verbose)
ebean.logging.txnCommit=none

woResponse

Upload a file