I have an entity (A) which has an embedded key and a n:1 association (B).
Both entity have some key columns with the same name.

As soon as autoFetch optimizes (it is not an autoFetch problem) the query by making the association eager fetched the column names are no longer unique, and the generated idBindSql in IdBinderEmbedded is missing the table alias - which creates an invalid sql then.

I am not sure if my patch here is a hack, at least it tries to get the dbAlias from "somewhere" in case the deploy itself does not define one, and then, when building the idBindSql one is available to prefix the column.

Index: ../ebean/src/com/avaje/ebean/server/deploy/BeanProperty.java
===================================================================
--- ../ebean/src/com/avaje/ebean/server/deploy/BeanProperty.java (revision 168)
+++ ../ebean/src/com/avaje/ebean/server/deploy/BeanProperty.java Fri Mar 13 10:47:45 CET 2009
@@ -248,7 +247,12 @@

this.dbColumn = deploy.getDbColumn();
this.dbFullName = deploy.getDbFullName();
+ if (deploy.getDbTableAlias() == null) {
+ this.dbTableAlias = descriptor.getBaseTableAlias();
+ }
+ else {
- this.dbTableAlias = deploy.getDbTableAlias();
+ this.dbTableAlias = deploy.getDbTableAlias();
+ }
this.sqlFormulaJoin = deploy.getSqlFormulaJoin();
this.sqlFormulaSelect = deploy.getSqlFormulaSelect();
this.formula = sqlFormulaSelect != null;
Index: ../ebean/src/com/avaje/ebean/server/deploy/id/IdBinderEmbedded.java
===================================================================
--- ../ebean/src/com/avaje/ebean/server/deploy/id/IdBinderEmbedded.java (revision 168)
+++ ../ebean/src/com/avaje/ebean/server/deploy/id/IdBinderEmbedded.java Fri Mar 13 10:40:01 CET 2009
@@ -133,6 +133,9 @@
if (i > 0) {
sb.append(" AND ");
}
+
+ sb.append(embIdProperty.getDbTableAlias());
+ sb.append(".");
sb.append(props[i].getDbFullName());
sb.append(" = ? ");
}